Skip to content

Expand Chapter 10: semantic logging - #23

Merged
koriym merged 7 commits into
masterfrom
expand-semantic-logging-chapter
Apr 16, 2026
Merged

koriym merged 7 commits into
masterfrom
expand-semantic-logging-chapter

Conversation

@koriym

@koriym koriym commented Apr 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace the 63-line stub with a full manual chapter (~160 lines)
  • Cover: auto-recorded metamorphosis logs, the Been carrier, event contexts, produced JSON structure
  • Bridge to Chapter 13 (LDD vision) at the end
  • Change category from Draft to Manual

Corresponds to framework PR be-framework/Be.Framework#59 which adds the Been carrier implementation.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Promoted semantic logging doc from Draft to Manual.
    • Replaced "basic concept" with a comparison of legacy logs vs structured semantic logs.
    • Added lifecycle-focused explanation (open/events/close) and clarified roles of compact proofs vs detailed event records.
    • Included full JSON examples showing sources, events, and close metadata.
    • Reframed value discussion toward "logs as DSL" and consolidated technical references.

Replace the 63-line placeholder with a full chapter covering
auto-recorded metamorphosis logs, the Been carrier, event contexts,
produced JSON structure, and the bridge to LDD.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@koriym has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 16 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 35 minutes and 16 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 45411b5c-d835-4132-b1ed-4829abdfd91f

📥 Commits

Reviewing files that changed from the base of the PR and between a1a16b4 and f2a7e86.

📒 Files selected for processing (2)
  • manuals/1.0/en/10-semantic-logging.md
  • manuals/1.0/ja/10-semantic-logging.md
📝 Walkthrough

Walkthrough

Japanese semantic-logging manual updated: front-matter category set to Manual; replaced the "basic concept" section with an open/events/close Becoming model; added detailed descriptions of $been/Been injection and with(), AbstractContext→context mapping, full JSON examples, and Log-Driven Development notes.

Changes

Cohort / File(s) Summary
Semantic Logging Documentation
manuals/1.0/ja/10-semantic-logging.md
Front-matter category changed to Manual. Removed prior "basic concept" text and placeholder notes. Introduced open/events/close Becoming model, documented $been and Been injection plus with() semantics, described AbstractContext→context mapping and event context fields (TYPE/SCHEMA_URL), added full JSON examples (metamorphosis_open/close, immanent/transcendent sources, events, close.context.properties, be), and added Log-Driven Development / DSL consolidation discussion. (+161/-29 lines)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I nibbled through lines at morning light,

open, events, close — a tidy sight,
Been hops in with context true,
JSON carrots in a row, anew,
From Draft to Manual, I cheer and bite 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Expand Chapter 10: semantic logging' directly and specifically reflects the main change: a substantial expansion of the Chapter 10 documentation from a 63-line stub to a full ~160-line manual chapter covering semantic logging concepts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch expand-semantic-logging-chapter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Apr 16, 2026

Copy link
Copy Markdown

Code Review

PR #23: Expand Chapter 10 — Semantic Logging (JA)

Overview

Replaces the 63-line Japanese stub with a full ~160-line chapter covering the Been carrier, auto-recorded metamorphosis logs, event context classes, the produced JSON structure, and a bridge to Chapter 13 (LDD). The category is promoted from Draft to Manual.


Issues

1. English version not updated (significant)

The Japanese page is promoted to category: Manual (and will now appear in the JA sidebar), but en/10-semantic-logging.md still has category: Draft with the old stub content. This creates an asymmetry:

  • JA sidebar: shows Chapter 10
  • EN sidebar: Chapter 10 is absent

CLAUDE.md also notes these pages are "intentionally hidden from the sidebar" — if the intent is to graduate JA to visible, the EN version should be updated in the same PR (or the PR description should explain the deliberate phasing).

2. Sidebar visibility is a side-effect of the category change

The mechanism hiding these pages from the sidebar is category: Draft (not sidebar: false as CLAUDE.md implies). Changing to category: Manual makes the chapter visible in the sidebar. This is likely intentional, but worth noting explicitly — the PR summary doesn't mention the sidebar change.


Positive aspects

  • Content structure is excellent. The open/events/close framing maps cleanly to the JSON output example, making the concept immediately tangible.
  • Code examples are idiomatic and consistent with Be Framework conventions seen elsewhere in the manual.
  • Links are valid. ./13-vision-ldd.html and ./11-reference-resources.html both have matching permalink values in their frontmatter.
  • The $been exclusion note ("ログが自分自身を含めば無限再帰になる") is a helpful implementation detail.
  • The LDD bridge at the end is well-placed — it earns the forward reference rather than just dropping a link.

Minor

  • The trailing emoji (➡️) in the last line is the only emoji in the documentation. Consistent with not using emojis unless requested, consider replacing with plain text: "フレームワークの全体像はリファレンスへ。"

Summary

The content itself is high quality and ready. The main thing to address before merging is the EN/JA parity gap — either update en/10-semantic-logging.md to match or explicitly scope this PR as JA-only with a follow-up issue for EN.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@manuals/1.0/ja/10-semantic-logging.md`:
- Around line 2-6: The frontmatter at the top of the
manuals/1.0/ja/10-semantic-logging.md file is missing the required sidebar
setting; update the YAML frontmatter block (the existing keys layout, title,
category, permalink) to include sidebar: false so the page is hidden from
navigation as intended (ensure the new key is placed within the frontmatter
block alongside layout/title/category/permalink).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: edc4a384-66be-406f-9bc0-7c971588c3f1

📥 Commits

Reviewing files that changed from the base of the PR and between 4115403 and 6b3d578.

📒 Files selected for processing (1)
  • manuals/1.0/ja/10-semantic-logging.md

Comment thread manuals/1.0/ja/10-semantic-logging.md
Align with framework PR #59 fix: email verification uses filter_var,
not regex. EmailFormatAssertedContext carries only the email address.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
manuals/1.0/ja/10-semantic-logging.md (1)

2-6: ⚠️ Potential issue | 🟠 Major

Add sidebar: false to hidden chapter frontmatter.

This page is one of the explicitly hidden chapters, but the frontmatter still omits sidebar: false.

Proposed fix
 layout: docs-ja
 title: "意味的ログ"
 category: Manual
+sidebar: false
 permalink: /manuals/1.0/ja/10-semantic-logging.html

As per coding guidelines, "Pages 10-semantic-logging and 13-vision-ldd are intentionally hidden from sidebar navigation and must have sidebar: false in frontmatter".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@manuals/1.0/ja/10-semantic-logging.md` around lines 2 - 6, This frontmatter
is missing the required sidebar setting for hidden chapters; update the
frontmatter of the 10-semantic-logging page by adding the key `sidebar: false`
alongside the existing `layout`, `title`, `category`, and `permalink` entries so
the page is explicitly excluded from the sidebar navigation (ensure `sidebar:
false` appears in the top YAML frontmatter block).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@manuals/1.0/ja/10-semantic-logging.md`:
- Around line 2-6: This frontmatter is missing the required sidebar setting for
hidden chapters; update the frontmatter of the 10-semantic-logging page by
adding the key `sidebar: false` alongside the existing `layout`, `title`,
`category`, and `permalink` entries so the page is explicitly excluded from the
sidebar navigation (ensure `sidebar: false` appears in the top YAML frontmatter
block).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 746b2dd2-47ea-4ac6-a949-b836de64c73a

📥 Commits

Reviewing files that changed from the base of the PR and between 6b3d578 and 454f21b.

📒 Files selected for processing (1)
  • manuals/1.0/ja/10-semantic-logging.md

koriym and others added 5 commits April 16, 2026 17:37
Restructure around developer perspective: $been for existence proof
first, SemanticLoggerInterface for hierarchical logging second,
auto-recorded metamorphosis last.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add descriptive/constitutive comparison table in overview
- Rewrite LDD section as open possibility, remove link to Ch.13
- Remove $been exclusion implementation detail
- Improve opening contrast with side-by-side output examples

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Explain traditional logs as disconnected text lines vs one JSON per transformation
- Replace vague "すべて" with "何が何になり、なぜそうなったか"
- Remove inaccurate "除去可否" row from comparison table
- Add "存在の証明" to the DSL section, mention test-level schema validation
- Rename section titles for clarity
- Move technical reference link to footer

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Explain what Been already contains when injected (from/to recorded at metamorphosis start)
- Clarify that $been is proof of identity, Logger is for intermediate steps like traditional logs
- Note that $been is usually sufficient

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace draft placeholder with full translation matching the Japanese version.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@koriym
koriym merged commit 453f93c into master Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant